Hi Jon,

On Wed, Mar 12, 2008 at 09:16:46AM -0400, Jon Masters wrote:

> *). The find-requires script/kmodtool interaction is indeed a little
> cryptic. Essentially, there's a catchall kmodtool in the distribution,
> but most kmods ship their own updated/modified one if they need to do
> anything a little different - most of the driver disks will use their
> own kmodtool due to the fact that some RHEL5 systems contain a kmodtool
> that calls rpm during installation, something not actually possible if
> you're trying to install the kmod from within Anaconda. This is
> something we corrected (example in the ddiskit sources too). [...]

I have two comments to to ddiskit version of kmodtool:

- I don't know how flexible "weak-modules" is, but isn't it better to
 append "-name '*.ko'" to the find command for modules (line 138)?

- You always include firmware, which causes an error when /lib/firmware
 isn't there. For this reason I suggest to change line 173 to:

=====================>> cut here <<==========================
  [ -z "$with_firmware" ] || echo "/lib/firmware/*"
=====================>> cut here <<==========================

  and add the following lines at the beginning of print_rpmtemplate():

=====================>> cut here <<==========================
with_firmware=
if [ "X${1}" == "X-f" ] ; then
  with_firmware=1
  shift
fi
=====================>> cut here <<==========================

 This enable you to add the flag -f in the rpmtemplate(_kmp) command
 of kmodtool, if and only if you want to include firmware files.
 This makes kmodtool more generic.

Cheers,

--
--   Jos Vos <jos@(protected)>
--   X/OS Experts in Open Systems BV  |  Phone: +31 20 6938364
--   Amsterdam, The Netherlands     |   Fax: +31 20 6948204

_______________________________________________
rhelv5-list mailing list
rhelv5-list@(protected)
https://www.redhat.com/mailman/listinfo/rhelv5-list