On Wed, 2008-03-12 at 15:47 +0100, Jos Vos wrote:

> I have two comments to to ddiskit version of kmodtool:
>
> - I don't know how flexible "weak-modules" is, but isn't it better to
>   append "-name '*.ko'" to the find command for modules (line 138)?

Yeah, in theory. But the reality is that we "only ever" (those famous
words) have modules in that location. I think I'll add that test though,
because when that stops being true sometime, it'd be nice not to break.

> - You always include firmware, which causes an error when /lib/firmware
>   isn't there. For this reason I suggest to change line 173 to:

I agree that some solution for firmware is good, though I'm not yet sure
what we should do. Is it failing to build for you, or are you just
saying that the /lib/firmware directory doesn't exist on a target?

Jon.


_______________________________________________
rhelv5-list mailing list
rhelv5-list@(protected)
https://www.redhat.com/mailman/listinfo/rhelv5-list