walluck wrote:
> Log:
> - 1.2

If you had read the changelog, you'd know that the only end-user change
in 1.2 is the removal of mimetype definition, which is not needed as of
shared-mime-info 0.30. We have only 0.23, which is why I hadn't released
this one yet.

> -Source0:     http://download.gna.org/nfoview/1.1/%{name}-%{version}.tar.gz
> -
> -BuildRequires:  intltool
> +Source0:     http://download.gna.org/nfoview/%{version}/nfoview-%{version}.tar.bz2
> +Source1:     http://download.gna.org/nfoview/%{version}/nfoview-%{version}.tar.bz2.sig
> +Source2:     http://download.gna.org/nfoview/%{version}/nfoview-%{version}.md5sum

Do you think .md5sum is really necessary? And does something use these
.sig and .md5sm files? If not, I'd rather not have them.

> +Requires:     pygtk2.0
> +Requires:     pygtk2.0-libglade
> +Suggests:     terminus-font
> +Requires(post): desktop-common-data
> +Requires(postun): desktop-common-data
> +Requires(post): desktop-file-utils
> +Requires(postun): desktop-file-utils
> +Requires(post): shared-mime-info
> +Requires(postun): shared-mime-info
> +BuildRequires: desktop-file-utils
> +BuildRequires: intltool
> BuildRequires: python-devel
> -BuildRequires:  pygtk2.0
> -BuildRequires:  pygtk2.0-libglade
> -BuildRoot:    %{_tmppath}/%{name}-%{version}
> -BuildArch:  noarch
> -
> +BuildRequires: pygtk2.0
> +BuildRequires: pygtk2.0-libglade
> %{py_requires}
> -Requires:  pygtk2.0
> -Requires:  pygtk2.0-libglade
> -Suggests:  terminus-font
> +BuildArch:    noarch
> +BuildRoot:    %{_tmppath}/%{name}-%{version}-%{release}-root

Why did you rearrange these?
I want buildrequires before requires.

> %description
> NFO Viewer is a simple viewer for NFO files, which are "ASCII" art in
> @@(protected) @@
> %{__python} setup.py build
>
> %install
> -rm -rf %{buildroot}
> +%{__rm} -rf %{buildroot}

Is this really useful?
I don't think so.

> %{__python} setup.py install --root=%{buildroot}
> -
> -%find_lang %name
> +%find_lang %{name}
> +%{_bindir}/desktop-file-validate %{buildroot}%{_datadir}/applications/nfoview.desktop

I don't like that one. If we want to do this, it should be automated in
rpm-mandriva-setup/spec-helper, not in %install of every .spec.

> %clean
> -rm -rf %{buildroot}
> +%{__rm} -rf %{buildroot}

IMO not useful.

> %post
> %{update_mime_database}
> @@(protected) @@
[...]
> +%defattr(0644,root,root,0755)

I'd rather not define default permissions, to be consistent with other
specs.

> +%doc AUTHORS COPYING ChangeLog INSTALL NEWS PKG-INFO README TODO

This is GPL, so we do not need COPYING. INSTALL is useless since it is
already installed. PKG-INFO is not documentation. ChangeLog is not
needed since NEWS is comprehensive and better for end-user.

> +%attr(0755,root,root) %{_bindir}/nfoview
> %{python_sitelib}/nfoview*
> %{_datadir}/applications/nfoview.desktop
> %{_mandir}/man1/nfoview.1*
> -%{_datadir}/mime/nfoview.xml

You remove the mime definition but forget to remove respective stuff
from %post and %postun.

--
Anssi Hannula