Le mercredi 11 juin 2008, Pixel a écrit :
> Olivier Thauvin <nanardon@(protected):
> > [nanardon@(protected)
> > "rpm -b" is deprecated, use "rpmbuild -b"
> > erreur: Missing %files for subpackage postgresql
> >
> > This is clearly a change in rpm behavior. For age, the rules as been: any
> > binary packages can exists, only packages having %files section are
> > generated.
>
> but is there any reason for this?

It is like this for years, don't know why but I clearly remember I found it in
a doc (can't remember which).

>
> > This changes will probably deny to us to build many packages, including
> > rpm not coming from mandriva.
>
> in any case, fixing this is really simple, see below.

This is not the point, what will happend if people cannot build rpm not
comming from mandriva ? Do you plan to reply yourself on forum to the
usuall "mandriva sucks, this spec works everywhere else".

Such change already happend in past, with a patch from gb, denying to people
to build openmotif (or something like that), not yet provided by mandriva in
this release.

My point is "this change break a standard behavior of rpm, maybe view as a
feature".

>
> but even if it's simple, if it's too much work to fix cooker packages
> regarding this, we'll disable the patch.

I don't have exact list of my packages using it, but at least the problem
already occur on:
- kernel-tmb
- postgresql8.2
- postgresql8.3

Not a large number of packages, but very complex spec file, making this
behavior usefull to avoid to repeat %if everywhere. Of course the other
solution is to reoder section inside the specfile, not sure it will help for
the readibility.

>
> as for non-mandriva packages, that's another issue.
> we could disable this error if %release doesn't match %distsuffix ?

And if the specfile was written (for mandriva 2008.1 maybe) according our
rules, like plf does ?

>
>
> --- postgresql8.3.spec  (revision 217878)
> +++ postgresql8.3.spec  (working copy)
> @@(protected) @@
> server, you need this package. You also need to install this package
> if you're installing the postgresql-server package.
>
> +%if %produce_client
> %package -n %{bname}
> Summary:  PostgreSQL client programs and libraries
> Group:    Databases
> @@(protected) @@
> If you want to manipulate a PostgreSQL database on a remote PostgreSQL
> server, you need this package. You also need to install this package
> if you're installing the postgresql-server package.
> +%endif
>
> %package -n  %{libname}
> Summary:  The shared libraries required for any PostgreSQL clients
> @@(protected) @@
> you're installing postgresql-server, you need to install this
> package.
>
> +%if %produce_devel
> %package  -n %{bname}-devel
> Summary:  PostgreSQL development header files and libraries
> Group:    Development/Databases
> @@(protected) @@
> develop applications which will interact with a PostgreSQL server. If
> you're installing postgresql-server, you need to install this
> package.
> +%endif
>
> %package  pl
> Summary:  Procedurals languages for PostgreSQL