Christiaan Welvaart wrote:
> On Thu, 12 Jun 2008, Pixel wrote:
>
>> Adam Williamson <awilliamson@(protected):
>>
>>> Okay, I really don't understand this underlinking stuff. And yes, I read
>>> the Wiki. But I still don't get it, or at least, how to fix problems.
>>>
>>> It's breaking Brasero's build:
>>>
>>> Making all in cdrdao
>>> make[4]: Entering directory
>>> `/home/adamw/rpm/BUILD/brasero-0.7.90/src/plugins/cdrdao'
>>> /bin/sh ../../../libtool --tag=CC  --mode=link gcc -g -O2 -g -pipe
>>> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
>>> --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586
>>> -mtune=generic -fasynchronous-unwind-tables -module -avoid-version
>>> -Wl,--as-needed -Wl,--no-undefined -o libbrasero-cdrdao.la -rpath
>>> /usr/lib/brasero/plugins burn-cdrdao.lo -lgconf-2 -lglib-2.0  
>>> -Wl,--as-needed -Wl,--no-undefined
>>> gcc -shared -Wl,--as-needed .libs/burn-cdrdao.o
>>> /usr/lib/libgconf-2.so /usr/lib/libglib-2.0.so  -march=i586
>>> -mtune=generic -Wl,--as-needed -Wl,--as-needed -Wl,--no-undefined
>>> -Wl,-soname -Wl,libbrasero-cdrdao.so -o .libs/libbrasero-cdrdao.so
>>> .libs/burn-cdrdao.o: In function `brasero_cdrdao_finalize':
>>> /home/adamw/rpm/BUILD/brasero-0.7.90/src/plugins/cdrdao/burn-cdrdao.c:528:
>>> undefined reference to `g_type_check_class_cast'
>>> .libs/burn-cdrdao.o: In function `brasero_cdrdao_class_init':
>>> /home/adamw/rpm/BUILD/brasero-0.7.90/src/plugins/cdrdao/burn-cdrdao.c:510:
>>> undefined reference to `g_type_check_class_cast'
>>> /home/adamw/rpm/BUILD/brasero-0.7.90/src/plugins/cdrdao/burn-cdrdao.c:511:
>>> undefined reference to `brasero_process_get_type'
>>> [...]
>>> how do I fix this?
>
>> a plugin should be built using libtool options "-module -avoid-version".
>> (and in that case, libtool will ensure --no-undefined is removed)
>
> As seen above, -module is already passed to libtool, so the problem
> seems to be somewhere else - either passing -Wl--no-undefined to libtool
> is wrong, or libtool should remove it from the command line.

It should, we are patching it do so.

--
Anssi Hannula