Thierry Vignaud wrote:
> anssi <svn-commit@(protected):
>
>> Log:
>> - XFdrake:
>>  o use nvidia-current default settings for nvidia173 as well
>
> maybe should we add a comment in the code.
> I fear we won't remember what we're doing next time (at least I won't).

You mean, you don't remember why this stuff is in there?
I think comments would be nice, maybe with links to bugreports. For all
the other default values in drakx-kbd-mouse-x11 as well.

AFAIK the RenderAccel is disabled on old proprietary drivers due to text
corruption issues.
https://qa.mandriva.com/show_bug.cgi?id=24999

However, see this log entry:
2006-08-28 12:24 Pixel <pixel at mandriva.com>
* perl-install/Xconfig/various.pm: re-enable RenderAccel by
default on nvidia proprietary driver (pb fixed with version 8774)

If it was fixed in 8774, then 96xx should be safe, and it should only be
needed with 71xx.

I don't know why we have IgnoreEDID for old proprietary drivers, though;
the ChangeLog of drakx contains this:

2003-12-04 14:14 Pixel <pixel at mandriva.com>
* perl-install/Xconfig/card.pm: use Options "IgnoreEDID" when using
the proprietary X driver "nvidia"

However, it was removed *before* 96xx was released (after 71xx, though):
2006-01-06 14:47 Thierry Vignaud <tvignaud at mandriva.com>
* perl-install/Xconfig/card.pm: option IgnoreEDID is no more needed
 with nvidia driver

This would suggest that it is only needed with 71xx, whatever the issue is.


From the above log entries it would look that both of these should be
only used with 71xx. Is anyone aware of the reason we have them with
96xx as well?


>> Modified: drakx-kbd-mouse-x11/trunk/lib/Xconfig/proprietary.pm
>> ==============================================================================
>> --- drakx-kbd-mouse-x11/trunk/lib/Xconfig/proprietary.pm  (original)
>> +++ drakx-kbd-mouse-x11/trunk/lib/Xconfig/proprietary.pm  Thu Jun 19 02:36:22 2008
>> @@(protected) @@
>>
>>  log::explanations("Using specific NVIDIA driver and GLX extensions");
>>  $card2->{DRI_GLX_SPECIAL} = 1;
>> -  $card2->{Options}{IgnoreEDID} = 1 if $card2->{DriverVersion} ne '-current';
>> +  $card2->{Options}{IgnoreEDID} = 1 if member($card2->{DriverVersion}, qw(71xx 96xx));
>>  $card2;
>>    } elsif ($card2->{Driver} eq 'fglrx') {
>>  $check_drv->('fglrx_drv', "fglrx$card2->{DriverVersion}") or return;
>>
>> Modified: drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm
>> ==============================================================================
>> --- drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm  (original)
>> +++ drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm  Thu Jun 19 02:36:22 2008
>> @@(protected) @@
>>  isLaptop => $isLaptop,
>>  xdm => 1,
>>  Composite => !($card->{Driver} eq 'fglrx' || $card->{Driver} eq 'nvidia' && $card->{DriverVersion} eq '71xx'),
>> -  if_($card->{Driver} eq 'nvidia', RenderAccel => $card->{DriverVersion} eq '-current',
>> +  if_($card->{Driver} eq 'nvidia', RenderAccel => !member($card->{DriverVersion}, qw(71xx 96xx)),
>>                        Clone => 0, ForceModeDVI => 0),
>>  if_($card->{Driver} eq 'savage', HWCursor => 1),
>>  if_($card->{Driver} eq 'intel' && $isLaptop, Clone => 0),
>


--
Anssi Hannula