Le Saturday 28 June 2008 10:40:14 fwang, vous avez écrit :
> Author: fwang
>
> Log:
> New version 0.3.7

can you be more verbose on you commit logs ?

> -%patch0 -p0
> -%patch100 -p0 -b .hal
> +#%patch0 -p0
> +#%patch100 -p0 -b .hal

you are not only updating, but you disabled some patches, it would be
interesting, to have this on the commit log, with the reason

> %patch102 -p0 -b .realpath
> %patch103 -p0 -b .refresh
>
> @@(protected) @@
> convert pixmaps/%{name}.png -geometry 16x16
> %{buildroot}%{_miconsdir}/%{name}.png
>
> # Create a helper script to launch gparted using hal-lock
> +mkdir -p %buildroot%_bindir
> cp %{SOURCE1} %{buildroot}%{_bindir}/
> chmod 755 %{buildroot}%{_bindir}/run-gparted
>
> #consolehelper
> -install -d $RPM_BUILD_ROOT%{_sbindir}
> -mv $RPM_BUILD_ROOT%{_bindir}/gparted $RPM_BUILD_ROOT%{_sbindir}

Here you remove this part, w/o explainations ( i do not tell you are wrong
doing this, just that some explainations never hurted ... )


--
Cordialement,
Nicolas LécureuilContributeur KDE pour Mandriva