Author Login
Post Reply
tv <svn-commit@(protected):
> Modified: drakx/trunk/perl-install/ugtk2.pm
> ==============================================================================
> --- drakx/trunk/perl-install/ugtk2.pm (original)
> +++ drakx/trunk/perl-install/ugtk2.pm Wed Aug 6 16:34:22 2008
> @@(protected) @@
> $::isInstall ? (banner => Gtk2::Banner->new($icon, $title || (get_default_step_items()))) : (),
> $::isStandalone && $banner_title && $icon ? (banner => Gtk2::Banner->new($icon, $banner_title)) : (),
> width => $opts{width}, height => $opts{height}, default_width => $opts{default_width}, default_height => $opts{default_height},
> - modal => (!$o->{pop_it} && !$::isInstall) && ($opts{modal} || $grab || $o->{grab}) || $o->{modal},
> + modal => !(!$o->{pop_it} && $::isInstall) && ($opts{modal} || $grab || $o->{grab}) || $o->{modal},
This double negation is not much readable, why not make it this way?
modal => ($o->{pop_it} || !$::isInstall) && ($opts{modal} || $grab || $o->{grab}) || $o->{modal},
--
Olivier Blin (blino) - Mandriva